Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Remove chartEmbeddablesEnabled feature flag and unused code #174591

Closed
wants to merge 17 commits into from
Closed

[SecuritySolution] Remove chartEmbeddablesEnabled feature flag and unused code #174591

wants to merge 17 commits into from

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jan 10, 2024 •
edited
Loading

Summary

Summary

#171287

chartEmbeddablesEnabled feature flag has been switched on, all the bar charts and area charts are rendered with Lens Embeddable. We can safely delete the unused code.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

angorayc and others added 15 commits December 19, 2023 17:21
@angorayc
rm unused code
fd302e9
@angorayc
Merge branch 'main' into issues-171287
9257f91
@angorayc
remove unused unused code - server
24cf478
@angorayc
remove alertsPreviewChartEmbeddablesEnabled feature flag
887874a
@angorayc
Merge branch 'main' into remove-alertsPreviewChartEmbeddablesEnabled
cddd1d9
@angorayc
clean up
93cacfa
@angorayc
Merge branch 'remove-alertsPreviewChartEmbeddablesEnabled' of github.…
719e774 
…com:angorayc/kibana into remove-alertsPreviewChartEmbeddablesEnabled
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/notice'
8547286
@angorayc
Merge branch 'main' of github.com:elastic/kibana into remove-alertsPr…
5371679 
…eviewChartEmbeddablesEnabled
@angorayc
Merge branch 'remove-alertsPreviewChartEmbeddablesEnabled' of github.…
b125ca6 
…com:angorayc/kibana into remove-alertsPreviewChartEmbeddablesEnabled
@angorayc
unit tests
dfde301
@angorayc
unit tests
27fc5ec
@angorayc
Merge branch 'main' of github.com:elastic/kibana into remove-alertsPr…
dc354b8 
…eviewChartEmbeddablesEnabled
@angorayc
unit test
98b200c
@angorayc
update unit tests
efb7d8c
@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc angorayc changed the title Issues 171287 rebased [SecuritySolution] Remove chartEmbeddablesEnabled feature flag and unused code Jan 11, 2024
@angorayc angorayc mentioned this pull request Jan 11, 2024
Closed
3 tasks
@angorayc
Copy link
Contributor Author

buildkite test this

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 11, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / AlertsCountPanel toggleQuery alertsPageChartsEnabled is false and toggleStatus=true, render
  • [job] [logs] Jest Tests #6 / AlertsCountPanel toggleQuery alertsPageChartsEnabled is false and toggleStatus=true, render
  • [job] [logs] Jest Tests #6 / AlertsCountPanel toggleQuery alertsPageChartsEnabled is true and isExpanded=true, render
  • [job] [logs] Jest Tests #6 / AlertsCountPanel toggleQuery alertsPageChartsEnabled is true and isExpanded=true, render
  • [job] [logs] Jest Tests #6 / ChartPanels 'Reset group by fields' context menu action Group by it resets the 'Group by' field to the default value, even if the user has triggered validation errors, when 'alertViewSelection' is 'table'
  • [job] [logs] Jest Tests #6 / ChartPanels 'Reset group by fields' context menu action Group by it resets the 'Group by' field to the default value, even if the user has triggered validation errors, when 'alertViewSelection' is 'table'
  • [job] [logs] Jest Tests #6 / ChartPanels 'Reset group by fields' context menu action Group by it resets the 'Group by' field to the default value, even if the user has triggered validation errors, when 'alertViewSelection' is 'trend'
  • [job] [logs] Jest Tests #6 / ChartPanels 'Reset group by fields' context menu action Group by it resets the 'Group by' field to the default value, even if the user has triggered validation errors, when 'alertViewSelection' is 'trend'
  • [job] [logs] Jest Tests #6 / ChartPanels 'Reset group by fields' context menu action Group by top it resets the 'Group by top' field to the default value, even if the user has triggered validation errors, when 'alertViewSelection' is 'table'
  • [job] [logs] Jest Tests #6 / ChartPanels 'Reset group by fields' context menu action Group by top it resets the 'Group by top' field to the default value, even if the user has triggered validation errors, when 'alertViewSelection' is 'table'
  • [job] [logs] FTR Configs #16 / dashboard Export import saved objects between versions "after all" hook for "applies default selected options list options to dashboard"
  • [job] [logs] Jest Tests #6 / formatAlertsData stack by a boolean field
  • [job] [logs] Jest Tests #6 / formatAlertsData stack by a boolean field
  • [job] [logs] Jest Tests #6 / formatAlertsData stack by a text field
  • [job] [logs] Jest Tests #6 / formatAlertsData stack by a text field
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / Inspect Explore pages inspect Hosts page inspect Hosts page
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / Inspect Explore pages inspect Hosts page inspect Hosts page
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / Inspect Explore pages inspect Network page inspect Network page
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / Inspect Explore pages inspect Network page inspect Network page
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / Inspect Explore pages inspect Users page inspect Users page
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / Inspect Explore pages inspect Users page inspect Users page
  • [job] [logs] Detection Engine - Security Solution Cypress Tests #2 / Sourcerer adds a pattern to the default index and correctly filters out auditbeat-* adds a pattern to the default index and correctly filters out auditbeat-*
  • [job] [logs] Detection Engine - Security Solution Cypress Tests #2 / Sourcerer adds a pattern to the default index and correctly filters out auditbeat-* adds a pattern to the default index and correctly filters out auditbeat-*
  • [job] [logs] Explore - Security Solution Cypress Tests #2 / url state sets and reads the url state for timeline by id sets and reads the url state for timeline by id
  • [job] [logs] Jest Tests #1 / utils formatToChartDataItem it should format data correctly
  • [job] [logs] Jest Tests #1 / utils formatToChartDataItem it should format data correctly
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should format Y tick to local string
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should format Y tick to local string
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should put legend on the right
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should put legend on the right
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should set default chartHeight
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should set default chartHeight
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should show legend by default
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should get correct default values it should show legend by default
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should set custom configs it should format y tick with custom formatter
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should set custom configs it should format y tick with custom formatter
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should set custom configs it should hide legend
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should set custom configs it should hide legend
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should set custom configs it should set custom chart height
  • [job] [logs] Jest Tests #1 / utils getBarchartConfigs it should set custom configs it should set custom chart height
  • [job] [logs] Jest Tests #1 / utils getCustomChartData should format data correctly
  • [job] [logs] Jest Tests #1 / utils getCustomChartData should format data correctly
  • [job] [logs] Jest Tests #1 / utils getCustomChartData should handle the case when no data provided
  • [job] [logs] Jest Tests #1 / utils getCustomChartData should handle the case when no data provided
  • [job] [logs] Jest Tests #6 / when the isChartEmbeddablesEnabled experimental feature flag is enabled renders LensEmbeddable
  • [job] [logs] Jest Tests #6 / when the isChartEmbeddablesEnabled experimental feature flag is enabled renders LensEmbeddable
  • [job] [logs] Jest Tests #6 / when the isChartEmbeddablesEnabled experimental feature flag is enabled should skip calling getAlertsRiskQuery
  • [job] [logs] Jest Tests #6 / when the isChartEmbeddablesEnabled experimental feature flag is enabled should skip calling getAlertsRiskQuery

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4865 4808 -57

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.4MB 11.2MB -140.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 64.2KB 64.2KB -40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angorayc @kibana-ci @kibanamachine